Re: [PATCH 1/2] replace: use a GIT_NO_REPLACE_OBJECTS env variable

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Nov 17, 2009, 07:42 UTC
Message-ID: <4B0253DA.1090003@viscovery.net>
In-Reply-To: <20091117051125.3588.91072.chriscool@tuxfamily.org>

Christian Couder schrieb:

Show 9 quoted lines

> diff --git a/git.c b/git.c
> index bd2c5fe..7f7d73d 100644
> --- a/git.c
> +++ b/git.c
> @@ -89,6 +89,9 @@ static int handle_options(const char ***argv, int *argc, int *envchanged)
>  				*envchanged = 1;
>  		} else if (!strcmp(cmd, "--no-replace-objects")) {
>  			read_replace_refs = 0;
> +			setenv(NO_REPLACE_OBJECTS_ENVIRONMENT, "", 1);

It is safer to set to a non-empty string, e.g., "1".

I think this variable should be added to the list in connect.c around line 630 so that it does not propagate to the remote end.

-- Hannes