Re: [PATCH 4/4] win32: Improve the conditional inclusion of WIN32 API code
- From
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
- Date
- Nov 4, 2009, 19:40 UTC
- Message-ID
- <4AF1D8B9.9040603@ramsay1.demon.co.uk>
- In-Reply-To
- <4AEFDE9D.6060200@viscovery.net>
Johannes Sixt wrote:
> It may be that I understand something incorrectly; but then I blame the > justification that you gave. In this case, it would be helpful to reword > the commit message, and perhaps add some results from your experiments. >
The discussion which lead to this patch, including the experiments, can be found in the email thread starting here:
http://thread.gmane.org/gmane.comp.version-control.git/129403
(along with some other unrelated stuff; but it's not a long read :)
In the above thread, Marius suggested API_WIN32, but I switched it around, since I thought it sounded better! I also thought about GIT_WIN32. Suggestions?
ATB, Ramsay Jones