git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/4] Makefile: keep MSVC and Cygwin configuration separate

From
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date
Nov 4, 2009, 19:29 UTC
Message-ID
<4AF1D605.1020900@ramsay1.demon.co.uk>
In-Reply-To
<4AEFDB6B.8010209@viscovery.net>
Johannes Sixt wrote:
> 
> I like the direction of this change, but I think that you must use ':='

Yeah, I've always been a bit sloppy with recursive assignment versus simple assignment when the value does not contain a variable reference ;-) So yes, you are right...

Show 8 quoted lines
> assignment, and I would put this right after the uname_* assignments at
> the beginning of the Makefile:
> 
>  uname_V := $(shell sh -c 'uname -v 2>/dev/null || echo not')
> +ifdef MSVC
> +	uname_S := Windows
> +	uname_O := Windows	# avoid cygwin configuration
> +endif
OK with me. (but you are avoiding the MinGW configuration as well...)

ATB, Ramsay Jones

Previous: Johannes Sixt
Message 3 of 3 in “Makefile: keep MSVC and Cygwin configuration separate”
  1. 3/4 Makefile: keep MSVC and Cygwin configuration separateRamsay Jones, Oct 27, 2009
  2. Johannes SixtNov 3, 2009
  3. Ramsay JonesNov 4, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.