git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC 2/2] completion: allow use without compiling

From
Stephen Boyd <bebarino@gmail.com>
Date
Oct 28, 2009, 07:29 UTC
Message-ID
<4AE7F2EB.1020904@gmail.com>
In-Reply-To
<7v63a0t29l.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
Show 15 quoted lines
> Stephen Boyd <bebarino@gmail.com> writes:
>> Ok. Following Junio's suggestion I think we would have to do the following:
>>
>> (1) Revert the rename (git-completion.bash.in -> git-completion.bash)
>>
>> (2) Add a "generation" mode to git-completion.bash.generate to
>> generate the lists and output them to a file
>>
>> (3) Add logic in git-completion.bash.generate to source the generated
>> file if it exists
>>
>> (4) Source git-completion.bash.generate in git-completion.bash to get
>> the functions moved there
>
> Sorry, I do not quite see why an extra *.generate script is necessary.

I'm still assuming the generation mode has to be sh agnostic, therefore requiring those functions to be in another *.generate script. Is that wrong?

Previous: Junio C Hamano
Message 12 of 12 in “pre-generated completion fix and RFC”
  1. 0/2 pre-generated completion fix and RFCStephen Boyd, Oct 26, 2009
  2. 1/2 completion: ignore custom merge strategies when pre-generatingStephen Boyd, Oct 26, 2009
  3. 2/2 completion: allow use without compilingStephen Boyd, Oct 26, 2009
  4. Junio C HamanoOct 26, 2009
  5. Clemens BuchacherOct 27, 2009
  6. Junio C HamanoOct 27, 2009
  7. Clemens BuchacherOct 28, 2009
  8. Stephen BoydOct 27, 2009
  9. Shawn O. PearceOct 27, 2009
  10. Stephen BoydOct 28, 2009
  11. Junio C HamanoOct 28, 2009
  12. Stephen BoydOct 28, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.