git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [msysGit] [PATCH v4 7/8] mingw: enable OpenSSL

From
Johannes Sixt <j.sixt@viscovery.net>
Date
Oct 21, 2009, 12:55 UTC
Message-ID
<4ADF04BB.10302@viscovery.net>
In-Reply-To
<40aa078e0910210543t2dcc2af6ie16eb0e49895788f@mail.gmail.com>
Erik Faye-Lund schrieb:
Show 15 quoted lines
> On Wed, Oct 21, 2009 at 2:15 PM, Johannes Sixt <j.sixt@viscovery.net> wrote:
>> I seem to have ack'ed this one too early. After testing in my environment,
>> I get:
>>
>> imap-send.o: In function `ssl_socket_perror':
>> D:\Src\mingw-git/imap-send.c:241: undefined reference to `ERR_get_error'
>> D:\Src\mingw-git/imap-send.c:241: undefined reference to `ERR_error_string'
>>
>> I need this patch in addition, and perhaps something similar is also
>> needed with MSVC:
> 
> Ah, yes - thanks for that one. I traced it a bit, and I found that it
> works for me without your patch because I'm using OpenSSL's sha1, so
> $(LIB_4_CRYPTO) is already included. Your fix is of course correct.
> I'll squash it in and resend.

Indeed, I observed the failure after I set BLK_SHA1=YesPlease. I did this exactly because it removes the dependency on libcrypto.dll from git.exe.

-- Hannes
Previous: Erik Faye-LundNext: Johannes Sixt
Message 13 of 14 in “imap-send: Windows support”
  1. 0/8 imap-send: Windows supportErik Faye-Lund, Oct 19, 2009
  2. 1/8 imap-send: remove useless uid codeErik Faye-Lund, Oct 19, 2009
  3. 2/8 imap-send: use separate read and write fdsErik Faye-Lund, Oct 19, 2009
  4. 3/8 imap-send: use run-command API for tunnelingErik Faye-Lund, Oct 19, 2009
  5. 4/8 imap-send: fix compilation-error on WindowsErik Faye-Lund, Oct 19, 2009
  6. 5/8 imap-send: build imap-send on WindowsErik Faye-Lund, Oct 19, 2009
  7. 6/8 mingw: wrap SSL_set_(w|r)fd to call _get_osfhandleErik Faye-Lund, Oct 19, 2009
  8. 7/8 mingw: enable OpenSSLErik Faye-Lund, Oct 19, 2009
  9. 8/8 MSVC: Enable OpenSSL, and translate -lcryptoErik Faye-Lund, Oct 19, 2009
  10. Johannes SixtOct 19, 2009
  11. Johannes SixtOct 21, 2009
  12. Erik Faye-LundOct 21, 2009
  13. Johannes SixtOct 21, 2009
  14. Johannes SixtOct 19, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.