asciidoc problem, and a possible fix

From: hachi <hachi@kuiki.net>
Date: Mar 24, 2010, 23:34 UTC
Message-ID: <4ABB29E2-6DB1-4712-A3E8-CD524983FB0B@kuiki.net>

Hello folks,

I had an issue building git on some centos 5 machines today, and in trying to interpret the error message I formed the attached patch.

The errors were:
xmlto: input does not validate (status 1)
/home/hachi/rpm/BUILD/git-1.7.0.3/Documentation/git-filter-branch.xml:463: parser error : PCDATA invalid Char value 7
Clone it with <literal>git clone +++0+++</literal>.  The clone
                                    ^
/home/hachi/rpm/BUILD/git-1.7.0.3/Documentation/git-filter-branch.xml:463: parser error : PCDATA invalid Char value 7
Clone it with <literal>git clone +++0+++</literal>.  The clone

I will happily admit that I don't know asciidoc, or the use of asciidoc in git.... but the +++ marker surrounding the url seems to not be used anywhere else in the documents directory, and I seem to be getting the appropriate output because of the `` surrounding the command.

I'm not subscribed to the list, but I'll try to watch for replies. Would anyone like to either tell me I did this wrong, or apply my fix?

Thanks much,

hachi

diff --git a/Documentation/git-filter-branch.txt b/Documentation/git-filter-branch.txt
index 020028c..4f71c17 100644
--- a/Documentation/git-filter-branch.txt
+++ b/Documentation/git-filter-branch.txt
@@ -386,7 +386,7 @@ objects until you tell it to.  First make sure that:
 Then there are two ways to get a smaller repository.  A safer way is
 to clone, that keeps your original intact.
 
-* Clone it with `git clone +++file:///path/to/repo+++`.  The clone
+* Clone it with `git clone file:///path/to/repo`.  The clone
   will not have the removed objects.  See linkgit:git-clone[1].  (Note
   that cloning with a plain path just hardlinks everything!)