Re: bug with .git file and aliases
- From
Michael J Gruber <git@drmicha.warpmail.net>
- Date
- Aug 11, 2009, 10:04 UTC
- Message-ID
- <4A814216.20708@drmicha.warpmail.net>
- In-Reply-To
- <20090720152117.GB5347@coredump.intra.peff.net>
Jeff King venit, vidit, dixit 20.07.2009 17:21:
Show 22 quoted lines
> On Mon, Jul 20, 2009 at 09:54:12AM -0400, Geoffrey Irving wrote: > >> git 1.6.3.3 has a bug related to .git file support and aliases. >> Specifically, if you make an alias for status and call it from a >> subdirectory, git status chdirs into the true .git dir but then >> chdir's back to the wrong place in order to run the lstats for status. >> The result is that git status thinks all files have disappeared. > > Yeah, this is a known problem. The problem is that the 'git' wrapper > sets up the environment only partially when running aliases, and then > the resulting command ends up confused about where the worktree is. I > really don't remember the specifics, but you can probably find some > discussion in the list archives. Fixing it, IIRC, required some > refactoring of the setup code (which I had hoped to get to at some > point, but I am way behind on my git todo list). > > Hmm. Poking around a bit, this seems related, but I don't know why I > never followed up: > > http://article.gmane.org/gmane.comp.version-control.git/72792 > > -Peff
...because it was up to the brave git-on-win folks to decide whether setenv() on win would be rewritten to not use putenv() when the value is "". J&J, has anything happened on the front or is it likely to? (I'm sorry I can't offer help, only moral support...)
Jeff's patch from Feb. 08 still applies more or less cleanly (with obvious adjustments) and makes the relevant tests pass (on Linux).
Michael