Re: [PATCH RFC 2/8] push: add push.default = mirror

From: Paolo Bonzini <paolo.bonzini@gmail.com>
Date: Jul 20, 2009, 21:14 UTC
Message-ID: <4A64DE38.5090805@gmail.com>
In-Reply-To: <7vocrfulpu.fsf@alter.siamese.dyndns.org>

Show 5 quoted lines

> I think this patch alone (regardless of the rest which I haven't read)
> probably makes sense.
>
> Except that I think the part below contradicts with the --mirror push
> semantics (see remote.c::match_refs()).

        if (!send_mirror && prefixcmp(src->name, "refs/heads/"))
                 continue;

The way I read this, send_mirror will send everything, even if it's outside refs/heads/*. So refs/*.

If we agree on the semantics, would you harvest it separately or should I resubmit?

Paolo