Re: [PATCH] clone: add --perm option to clone an shared repository
- From
Paolo Bonzini <bonzini@gnu.org>
- Date
- Jun 22, 2009, 10:19 UTC
- Message-ID
- <4A3F5AC0.20207@gnu.org>
- In-Reply-To
- <alpine.DEB.1.00.0906221134090.4168@intel-tinevez-2-302>
Johannes Schindelin wrote:
Show 13 quoted lines
> Hi, > > On Mon, 22 Jun 2009, Paolo Bonzini wrote: > >> Roy Lee wrote: >>> The term 'shared' used here is in the same context with git init. >>> Unfortunately the 'shared' option has been taken, so I took the "perm" >>> as a place holder in this patch. Any comments? >> I think it would make sense to add "perm" to git-init too (and possibly >> deprecate --shared). > > Agreed. After we teach everybody on this planet that "perm" means > "shared", and "shared" does not.
Or instead of teaching everybody on this planet that "shared" means "set permissions for sharing" in one context, and "use hard links and set up .git/objects/info/alternates, which by the way may be dangerous" in another. :-)
But you made me think, and maybe it is better to remove argument-less --shared instead. What Roy introduced seems much more useful in practice.
Paolo