Re: [PATCH] git-format-patch, git-send-email: generate/handle escaped >From

From: Paolo Bonzini <paolo.bonzini@gmail.com>
Date: Jun 11, 2009, 11:58 UTC
Message-ID: <4A30F16C.5040207@gmail.com>
In-Reply-To: <20090611105538.GA4409@coredump.intra.peff.net>

Show 5 quoted lines

> But of course, which conversion you want depends entirely on what you
> are going to feed it to, and which mbox they are expecting. Which is why
> it really should be configurable.
> 
> Your use case looks to be feeding it to send-email

Almost, :-) because git-send-email does not support sending multiple messages out of one mbox file. I have an upcoming patch to add this support, and I was just "feeling the waters" before posting it.

Show 8 quoted lines

> I suspect you would
> be better served by improving the 'From ' detection in send-email,
> probably to something like:
> 
>   /^From \S+ \w{3} \w{3} \d+ \d\d:\d\d:\d\d \d+/
> 
> though that may be too strict. It would probably make sense to steal one
> from one of the many mbox-reading CPAN modules.

Good idea. I'll let others speak and can make this configurable (as well as use the s/^>*From />&/ conversion), but if no one speaks, I'll change my git-send-email patch to use the above regex or a similar one, and withdraw this patch.

Thanks for the prompt remark!

Paolo