Re: [PATCH] doc tweak for git-send-email

From: Stephen Boyd <bebarino@gmail.com>
Date: Jun 11, 2009, 00:57 UTC
Message-ID: <4A30568E.7060503@gmail.com>
In-Reply-To: <1244656571-15560-1-git-send-email-bonzini@gnu.org>

Paolo Bonzini wrote:

Show 20 quoted lines

> The git-send-email docs do not mention except in the usage lines
> the combined patch formatting/sending ability of git-send-email.
> This fills the hole.
>
> Signed-off-by: Paolo Bonzini <bonzini@gnu.org>
> ---
>  Documentation/git-send-email.txt |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt
> index eb851b3..02bb0d3 100644
> --- a/Documentation/git-send-email.txt
> +++ b/Documentation/git-send-email.txt
> @@ -33,6 +33,9 @@ script
>  This format expects the first line of the file to contain the "Cc:" value
>  and the "Subject:" of the message as the second line.
>  
> +In addition, git send-email can be asked to generate patches with git
> +format-patch and send them.
> +

You are right that the docs don't mention this feature very clearly, but this patch doesn't fill the hole for me.

How do I tell send-email to generate patches with format-patch? I know from looking at the code that send-email actually calls format-patch with the rev-list passed on the command line.

Maybe it would be more clear to say that rev-list can be specified in the same way as format-patch? Also, could you update the first sentence in the description section? Obviously send-email takes more than just patches on the command line.