git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 6/6] mktree --missing: allow missing objects

From
René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date
May 10, 2009, 22:13 UTC
Message-ID
<4A075195.5020508@lsrfire.ath.cx>
In-Reply-To
<1241981391-19639-7-git-send-email-gitster@pobox.com>
Junio C Hamano schrieb:
Show 19 quoted lines
> -static void mktree_line(char *buf, size_t len, int line_termination)
> +static void mktree_line(char *buf, size_t len, int line_termination, int allow_missing)
>  {
>  	char *ptr, *ntr;
>  	unsigned mode;
> @@ -92,9 +92,12 @@ static void mktree_line(char *buf, size_t len, int line_termination)
>  
>  	/* It is perfectly normal if we do not have a commit from a submodule */
>  	if (!S_ISGITLINK(mode))
> +		allow_missing = 1;
> +
> +	if (!allow_missing)
>  		type = sha1_object_info(sha1, NULL);
>  	else
> -		type = OBJ_COMMIT;
> +		type = object_type(mode);
>  
>  	if (type < 0)
>  		die("object %s unavailable", sha1_to_hex(sha1));
Don't you need this, above?
-  	if (!S_ISGITLINK(mode))
+	if (S_ISGITLINK(mode))
René
Previous: Junio C HamanoNext: Junio C Hamano
Message 14 of 16 in “questions about git-mktree”
  1. Jon SeymourMay 10, 2009
  2. Uwe Kleine-KönigMay 10, 2009
  3. A Large Angry SCMMay 10, 2009
  4. Jakub NarebskiMay 10, 2009
  5. Junio C HamanoMay 10, 2009
  6. Junio C HamanoMay 10, 2009
  7. 0/6 Modernize mktree somewhatJunio C Hamano, May 10, 2009
  8. 1/6 build-in git-mktreeJunio C Hamano, May 10, 2009
  9. 2/6 mktree: use parse-optionsJunio C Hamano, May 10, 2009
  10. 3/6 builtin-mktree.c: use a helper function to handle one line of inputJunio C Hamano, May 10, 2009
  11. 4/6 mktree: do not barf on a submodule commitJunio C Hamano, May 10, 2009
  12. 5/6 t1010: add mktree testJunio C Hamano, May 10, 2009
  13. 6/6 mktree --missing: allow missing objectsJunio C Hamano, May 10, 2009
  14. René ScharfeMay 10, 2009
  15. Junio C HamanoMay 11, 2009
  16. Josh MicichMay 10, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.