Re: [PATCH/RFC] daemon.c: replace inet_ntop with getnameinfo

From: Andreas Ericsson <ae@op5.se>
Date: May 7, 2009, 12:41 UTC
Message-ID: <4A02D70B.6090305@op5.se>
In-Reply-To: <4A02D288.6040804@googlemail.com>

Benjamin Kramer wrote:

Show 13 quoted lines

> git daemon's interpolated paths didn't support IPv6.
> Every IPv6 address was being converted to `0.0.0.0'.
> 
> Fix this by replacing inet_ntop(3) with the protocol
> agnostic getnameinfo(3) API.
> 
> Signed-off-by: Benjamin Kramer <benny.kra@googlemail.com>
> ---
> 
> With this patch we'll have colons in the per-IP directories
> for IPv6 addresses. Creating files with a : in the name fails
> on some OSes (e.g. Windows).
>

What per-IP directories are you talking about?

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231

Register now for Nordic Meet on Nagios, June 3-4 in Stockholm
 http://nordicmeetonnagios.op5.org/

Considering the successes of the wars on alcohol, poverty, drugs and
terror, I think we should give some serious thought to declaring war
on peace.