git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] To make GIT-VERSION-FILE, search for git more widely

From
Michael J Gruber <git@drmicha.warpmail.net>
Date
May 7, 2009, 09:02 UTC
Message-ID
<4A02A39A.3000407@drmicha.warpmail.net>
In-Reply-To
<4A02A008.30800@viscovery.net>
Johannes Sixt venit, vidit, dixit 07.05.2009 10:47:
Show 17 quoted lines
> Junio C Hamano schrieb:
>> Matthias Andree <matthias.andree@gmx.de> writes:
>>
>>> Problem: when git is installed into /usr/local/bin, running 'sudo make
>>> install' won't find git in $PATH (because sudo strips PATH, for instance
>>> on openSUSE 11.1, and doesn't include /usr/local/whatever).
>>
>> That sounds like a bug/misfeature in sudo (which I do not use) to me.
> 
> sudo resets the environment, in particular also PATH. Why would this be a bug?
> 
> Current distros set env_reset in /etc/soduers for a reason. Not that I
> know the reason in detail, but I won't claim that I'm more clever with
> regards to security issues than distro packagers; so I trust that if they
> do it, then it makes sense.
> 
> -- Hannes

sudo's behaviour is fine, but the OP's is not: doing "sudo make install" amounts to building git as root, unless you have done a make as non-root before. If you have done that make then GIT-VERSION-FILE will be up-to-date, and GIT-VERSION-GEN will not even be called by "make install".

So I think the proposed patch would encourage wrong behaviour. (also, the commit message mixes up ...-GEN and ...-FILE)

Michael
Previous: Johannes SixtNext: Matthias Andree
Message 9 of 13 in “To make GIT-VERSION-FILE, search for git more widely”
  1. To make GIT-VERSION-FILE, search for git more widelyMatthias Andree, May 7, 2009
  2. Johannes SixtMay 7, 2009
  3. Junio C HamanoMay 7, 2009
  4. Matthias AndreeMay 7, 2009
  5. Re: To make GIT-VERSION-FILE, search for git more widelyNicolas Sebrecht, May 7, 2009
  6. Matthias AndreeMay 7, 2009
  7. Re: To make GIT-VERSION-FILE, search for git more widelyNicolas Sebrecht, May 7, 2009
  8. Johannes SixtMay 7, 2009
  9. Michael J GruberMay 7, 2009
  10. Matthias AndreeMay 7, 2009
  11. Matthias AndreeMay 7, 2009
  12. Johannes SixtMay 7, 2009
  13. To make GIT-VERSION-FILE, search for git more widelyMatthias Andree, May 7, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.