Re: [PATCH v2 0/5] fetch: more optimizations for mirror fetches
- From
Derrick Stolee <derrickstolee@github.com>
- Date
- Mar 2, 2022, 18:54 UTC
- Message-ID
- <49c21bac-0543-7c3e-33f2-d36cdac87362@github.com>
- In-Reply-To
- <cover.1646127015.git.ps@pks.im>
On 3/1/2022 4:33 AM, Patrick Steinhardt wrote:
Show 12 quoted lines
> Hi, > > this is another patch series with the aim to speed up mirror fetches. It > applies on top of e6ebfd0e8c (The sixth batch, 2022-02-18) with > 3824153b23 (Merge branch 'ps/fetch-atomic' into next, 2022-02-18) merged > into it to fix a conflict. > > The only change compared to v2 is an update to the benchmarks so that > they're less verbose, as proposed by Derrick. I also had a look at > introducing a new helper `parse_object_probably_commit()`, but I didn't > find the end result to be much of an improvement compared to the ad-hoc > `lookup_commit_in_graph() || parse_object()` dance we do right now.
I'm satisfied that you tried the helper idea. This version looks good to me.
Thanks, -Stolee