Re: git 1.5.4.3 push incorrectly honors grafts file

From: Johannes Sixt <j6t@kdbg.org>
Date: May 4, 2009, 17:25 UTC
Message-ID: <49FF2507.6070602@kdbg.org>
In-Reply-To: <atsddmx5kuva.1fyy780hhh9t2$.dlg@40tude.net>

elupus schrieb:

Show 26 quoted lines

> On Mon, 27 Apr 2009 17:51:05 +0200, elupus wrote:
> 
>> Hi, 
>>
>> I recently had a problem with git push honoring the grafts file. It caused
>> it not to push all data required for a branch to the remote repository,
>> rendering it impossible to clone the remote repository (missing blobs)
>>
>> This was with an not so fresh git version of 1.5.4.3 (ubuntu hardy).
>>
>> Has this issue been fixed in later git version? I saw a thread talking
>> about it a long time ago (long before my release in question) on this
>> mailing list, but nothing was mentioned about if it was actually solved.
>>
>> Regards
>> Joakim Plate
> 
> Bump, anybody know of a way to avoid this? The problem even occurs on the
> local machine in that git gc will cleanup stuff that isn't required due to
> the grafts file, rendering the repo invalid if the graft file is removed.
> 
> I don't think running filter-branch on the git svn imported branches seems
> like a good idea. since that would also wreak havoc on any repo that pulls
> from mine (ie still private repo like usb stick or other dev machine). 
> 
> Imho, grafts shouldn't be honored on either push/pull/gc operations.

Right.

It's a know issue. But it was nobody's itch, yet, perhaps because too few people use grafts. There is a topic, cc/replace, in Junio's pu branch that introduces "replacement objects"; these are a generalization of grafts. If effort is invested, then it's best to nurse this topic.

-- Hannes