Re: [PATCH] git-svn: persistent memoization
On Jan 31, 2010, at 8:03 PM, Eric Wong wrote:
Show 23 quoted lines
> Andrew Myrick <amyrick@apple.com> wrote:
>> Make memoization of the svn:mergeinfo processing functions persistent with
>> Memoize::Storable so that the memoization tables don't need to be regenerated
>> every time the user runs git-svn fetch.
>>
>> The Memoize::Storable hashes are stored in ENV{GIT_DIR}/svn/caches.
>
> Hi Andrew,
>
> Perhaps "$ENV{GIT_DIR}/svn/.caches" is better here since older versions
> of git svn used "$ENV{GIT_DIR}/svn/$refname" in the top-level and
> "caches" may conflict with existing repos.
>
>> -use File::Path qw/mkpath/;
>> +use File::Path qw/mkpath make_path/;
>
> File::Path::make_path is very recent not in Perls distributed by most
> vendors. My 5.10.0 installation (Debian stable) doesn't have it, and I
> also don't see a good reason to use it over the traditional mkpath.
>
> I think I'll squash the following patch and Ack. Let me know if
> you have any objections, thanks.!
> (also wraps long lines to 80 chars)Makes sense to me. Thanks, Eric.
-Andrew
Andrew Myrick <amyrick@apple.com>