git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [JGIT RFC PATCH 2/2] Rewrite WindowCache to be easier to follow and maintain

From
Ferry Huberts (Pelagic) <ferry.huberts@pelagic.nl>
Date
Apr 30, 2009, 07:34 UTC
Message-ID
<49F9549F.3000702@pelagic.nl>
In-Reply-To
<20090429171659.GF23604@spearce.org>
Shawn O. Pearce wrote:
Show 16 quoted lines
> Robin Rosenberg <robin.rosenberg.lists@dewire.com> wrote:
>>> diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/OffsetCache.java b/org.spearce.jgit/src/org/spearce/jgit/lib/OffsetCache.java
>>> +	private void gc() {
>>> +		R r;
>>> +		while ((r = (R) queue.poll()) != null) {
>>> +			// Sun's Java 5 and 6 implementation have a bug where a Reference
>>> +			// can be enqueued and dequeued twice on the same reference queue
>>> +			// due to a race condition within ReferenceQueue.enqueue(Reference).
>> Reference to the official Sun bug? Might help if someone wants to
>> implement a flag to avoid this (if necessary...)
> 
> Actually, this is a new bug.  I tried looking through BugParade
> but nobody has mentioned or discovered this before.
> 
> I submitted a bug report yesterday, but they have yet to publish it.
> 

maybe you can also submit it to the OpenJDK folks? I have very bad experiences with reporting java bugs to sun. I reported a few and _never_ heard back from them, no publish of the bug, no reject, nothing.

Great work on rewriting this! PS. still need your input on ignores :-)

Previous: Shawn O. PearceNext: Shawn O. Pearce
Message 7 of 8 in “Don't use ByteWindows when checking pack file headers/footers”
  1. 1/2 Don't use ByteWindows when checking pack file headers/footersShawn O. Pearce, Apr 28, 2009
  2. 2/2 Rewrite WindowCache to be easier to follow and maintainShawn O. Pearce, Apr 28, 2009
  3. Shawn O. PearceApr 28, 2009
  4. Robin RosenbergApr 28, 2009
  5. Shawn O. PearceApr 28, 2009
  6. Shawn O. PearceApr 29, 2009
  7. Ferry Huberts (Pelagic)Apr 30, 2009
  8. Link to the Sun JVM bug mentioned in OffsetCacheShawn O. Pearce, May 6, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.