Re: [JGIT RFC PATCH 2/2] Rewrite WindowCache to be easier to follow and maintain
- From
Ferry Huberts (Pelagic) <ferry.huberts@pelagic.nl>
- Date
- Apr 30, 2009, 07:34 UTC
- Message-ID
- <49F9549F.3000702@pelagic.nl>
- In-Reply-To
- <20090429171659.GF23604@spearce.org>
Shawn O. Pearce wrote:
Show 16 quoted lines
> Robin Rosenberg <robin.rosenberg.lists@dewire.com> wrote:
>>> diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/OffsetCache.java b/org.spearce.jgit/src/org/spearce/jgit/lib/OffsetCache.java
>>> + private void gc() {
>>> + R r;
>>> + while ((r = (R) queue.poll()) != null) {
>>> + // Sun's Java 5 and 6 implementation have a bug where a Reference
>>> + // can be enqueued and dequeued twice on the same reference queue
>>> + // due to a race condition within ReferenceQueue.enqueue(Reference).
>> Reference to the official Sun bug? Might help if someone wants to
>> implement a flag to avoid this (if necessary...)
>
> Actually, this is a new bug. I tried looking through BugParade
> but nobody has mentioned or discovered this before.
>
> I submitted a bug report yesterday, but they have yet to publish it.
> maybe you can also submit it to the OpenJDK folks? I have very bad experiences with reporting java bugs to sun. I reported a few and _never_ heard back from them, no publish of the bug, no reject, nothing.
Great work on rewriting this! PS. still need your input on ignores :-)