git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-gui: fix use of undeclared variable diff_empty_count

From
JBJoerg Bornemann <joerg.bornemann@web.de>
Date
Apr 6, 2009, 19:59 UTC
Message-ID
<49DA5F20.4030800@web.de>

Commit 584fa9cc introduced the global variable diff_empty_count, which is used in diff.tcl. This variable wasn't declared anywhere which resulted in an ugly error message box instead of the intended informative message.

Signed-off-by: Joerg Bornemann <joerg.bornemann@web.de>
---
  git-gui.sh |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/git-gui.sh b/git-gui.sh
index e4a9230..46b056f 100755
--- a/git-gui.sh
+++ b/git-gui.sh
@@ -1131,6 +1131,7 @@ set current_diff_path {}
  set is_3way_diff 0
  set is_conflict_diff 0
  set selected_commit_type new
+set diff_empty_count 0

  set nullid "0000000000000000000000000000000000000000"
  set nullid2 "0000000000000000000000000000000000000001"
--
1.6.0.2.1172.ga5ed0
Next: Joerg Bornemann
Message 1 of 2 in “git-gui: fix use of undeclared variable diff_empty_count”
  1. git-gui: fix use of undeclared variable diff_empty_countJoerg Bornemann, Apr 6, 2009
  2. Joerg BornemannApr 7, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.