Re: [PATCH] mailmap: resurrect lower-casing of email addresses
- From
A Large Angry SCM <gitzilla@gmail.com>
- Date
- Apr 2, 2009, 22:22 UTC
- Message-ID
- <49D53ABF.80706@gmail.com>
- In-Reply-To
- <f182fb1700e8dea15459fd02ced2a6e5797bec99.1238458535u.git.johannes.schindelin@gmx.de>
{I may be late to this change since I'm trying to catch up on the ML.] Johannes Schindelin wrote:
> Commit 0925ce4(Add map_user() and clear_mailmap() to mailmap) broke the > lower-casing of email addresses. This mostly did not matter if your > .mailmap has only lower-case email addresses; However, we did not > require .mailmap to contain lowercase-only email addresses.
What part of the email address is this going to lowercase? Only the domain name is case agnostic.
Show 27 quoted lines
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
> lezzee how that goes
> mailmap.c | 9 +++++++++
> 1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/mailmap.c b/mailmap.c
> index f12bb45..6be91b6 100644
> --- a/mailmap.c
> +++ b/mailmap.c
> @@ -50,6 +50,15 @@ static void add_mapping(struct string_list *map,
> {
> struct mailmap_entry *me;
> int index;
> + char *p;
> +
> + if (old_email)
> + for (p = old_email; *p; p++)
> + *p = tolower(*p);
> + if (new_email)
> + for (p = new_email; *p; p++)
> + *p = tolower(*p);
> +
> if (old_email == NULL) {
> old_email = new_email;
> new_email = NULL;