git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add diffuse as merge and diff tool

From
SPSebastian Pipping <webmaster@hartwork.org>
Date
Mar 30, 2009, 16:41 UTC
Message-ID
<49D0F63D.2050205@hartwork.org>
In-Reply-To
<20090330045522.GA8308@gmail.com>
David Aguilar wrote:
Show 12 quoted lines
>>  Documentation/git-mergetool.txt        |    3 ++-
>>  Documentation/merge-config.txt         |    7 ++++---
>>  contrib/completion/git-completion.bash |    3 ++-
>>  contrib/difftool/git-difftool-helper   |   12 ++++++++----
>>  contrib/difftool/git-difftool.txt      |    4 ++--
>>  git-gui/lib/mergetool.tcl              |    7 +++++++
>>  git-mergetool.sh                       |   15 ++++++++++++---
>>  7 files changed, 37 insertions(+), 14 deletions(-)
> 
> 
> Hey, thanks for the patch.
> Ouch.. too many places with duplicated information, huh?
Yes.
Show 18 quoted lines
> I'm in the middle of refactoring git-(diff|merge)tool so that
> there is less duplication of code.
> 
> Junio also has a number of difftool-related patches in his
> proposed-updates "pu" branch.
> 
> Sebastian, would you mind if I rebased your patch on top of my
> work (once I send it out) so that it makes things easier on
> our kind maintainer?  I have a big patch series coming down that
> does away with the redundancies so I think it'd be best if we
> transfered your changes on top of it.  Would you mind if I
> rebased your patch and sent it out to the list?
> 
> It wouldn't be until much later tonight (or tomorrow) at the
> earliest since I have some unpacking to take care of but if
> that's cool with you just let me know.
> 
> You should see the refactoring patches from me shortly...
My patch is your patch, do as you please.

Just take care to keep the order of the files passed to Diffuse intact, especially with $MERGED second, as Diffuse sets focus on the second document after startup.

Sebastian
Previous: David Aguilar
Message 3 of 3 in “Add diffuse as merge and diff tool”
  1. Add diffuse as merge and diff toolSebastian Pipping, Mar 28, 2009
  2. David AguilarMar 30, 2009
  3. Sebastian PippingMar 30, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.