Re: [RFC/PATCH 2/8] docbook: improve css style

From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Mar 24, 2009, 08:29 UTC
Message-ID: <49C899E1.6060809@drmicha.warpmail.net>
In-Reply-To: <94a0d4530903231721i2a2a6fc1yf54d4303283ec415@mail.gmail.com>

Felipe Contreras venit, vidit, dixit 24.03.2009 01:21:

Show 30 quoted lines

> On Mon, Mar 23, 2009 at 5:20 PM, Michael J Gruber
> <git@drmicha.warpmail.net> wrote:
>> Felipe Contreras venit, vidit, dixit 23.03.2009 11:31:
>>> On Mon, Mar 23, 2009 at 8:42 AM, Jeff King <peff@peff.net> wrote:
>>>> On Sun, Mar 22, 2009 at 08:05:15PM +0200, Felipe Contreras wrote:
>>>>
>>>>>  tt.literal, code.literal {
>>>>>    color: navy;
>>>>> +  font-size: 1em;
>>>>> +}
>>>>
>>>> Isn't 1em already the default size? Or are you trying to override some
>>>> other size specification elsewhere? It's hard to tell what the goal is
>>>> because your commit message merely says "improve".
>>>
>>> That's correct.
>>>
>>> The problem is that when the user has a different size for the
>>> sans-serif and monospace fonts it looks horrible when they are on the
>>> same paragraph. I thought 1em did the trick, but you are right, it
>>> doesn't.
>>>
>>> It looks like the only way to fix this is to set absolute sizes.
>>>
>>
>> Also, it seems that everything which is not black is blue, except for
>> terms, which are green and slanted. I don't think that looks nice
>> together. How about slanted blue?
> 
> What's wrong with having 2 colors?

I don't mind having 2, they just don't look good together over here, on my screen and to my eyes...

Right now we have "plain old asciidoc look" which doesn't look that old after all. You pointed out a deficiency, and I'm all for fixing it. I just think that introducing new colors is something that may require a ground up rethinking of the theme being used: make it informative but unobtrusive. Also, I'm against over-emphasizing: use slanted or a specific color, but not both. Unless one color means emphasizing and slanted means file, for example.

Michael