git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Documentation: Reworded example text in git-bisect.txt.

From
David J. Mellor <dmellor@whistlingcat.com>
Date
Mar 22, 2009, 21:39 UTC
Message-ID
<49C6AFF9.6090204@whistlingcat.com>
In-Reply-To
<200903210528.32392.chriscool@tuxfamily.org>
On 03/20/2009 09:28 PM, Christian Couder wrote:
Show 43 quoted lines
> Le vendredi 20 mars 2009, David J. Mellor a écrit :
> 
> [...]
> 
>> @@ -94,14 +95,14 @@ the bisection state).
>>  Bisect visualize
>>  ~~~~~~~~~~~~~~~~
>>
>> -During the bisection process, you issue the command:
>> +To see the currently remaining suspects in 'gitk', the following command
>> +is issued during the bisection process:
> 
> I think it's better to avoid the passive tone, for example like this:
> 
> "To see the currently remaining suspects in 'gitk', you issue the following 
> command during the bisection process:"
> 
>>  ------------
>>  $ git bisect visualize
>>  ------------
> 
> [...]
> 
>> @@ -173,8 +175,8 @@ using the "'<commit1>'..'<commit2>'" notation. For
>> example: $ git bisect skip v2.5..v2.6
>>  ------------
>>
>> -would mean that no commit between `v2.5` excluded and `v2.6` included
>> -can be tested.
>> +The effect of this would be that no commit between `v2.5` excluded and
>> +`v2.6` included could be tested.
> 
> I'd prefer something like:
> 
> "This tells the bisect process that no commit between `v2.5` excluded and 
> `v2.6` included can be tested."
> 
> Otherwise it looks good to me.
> 
> Thanks,
> Christian.
> 
> 

I will send a patch correcting this in my next cycle of documentation patches. I should send them some time later today.

Previous: Christian CouderNext: J. Bruce Fields
Message 4 of 5 in “Documentation: Reworded example text in git-bisect.txt.”
  1. Documentation: Reworded example text in git-bisect.txt.David J. Mellor, Mar 20, 2009
  2. Michael J GruberMar 20, 2009
  3. Christian CouderMar 21, 2009
  4. David J. MellorMar 22, 2009
  5. J. Bruce FieldsMar 23, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.