Re: [PATCH 1/2] Add a test for checking whether gitattributes is honored by checkout.
- From
- Kristian Amlie <kristian.amlie@nokia.com>
- Date
- Mar 12, 2009, 09:53 UTC
- Message-ID
- <49B8DB81.7020100@nokia.com>
- In-Reply-To
- <vpqr613jcoa.fsf@bauges.imag.fr>
ext Matthieu Moy wrote:
Show 9 quoted lines
> Kristian Amlie <kristian.amlie@nokia.com> writes: > >> +test_expect_success 'setup' ' > > If you have two separate patches for test and bugfix, you probably > want the first to introduce test_expect_failure, and the second to > change it to test_expect_success. This way: 1) the test-suite passes > for all commits (and git-bisect will be your friend again), and 2) the > second patch is self-explanatory about the bug it fixes.
Good point. I'll fix that in my next batch.
-- Kristian