Re: Help designing work flow
- From
Andreas Ericsson <ae@op5.se>
- Date
- Mar 9, 2009, 13:28 UTC
- Message-ID
- <49B51994.1040200@op5.se>
- In-Reply-To
- <43d8ce650903090622j51b73801gb4be62a7f50029a4@mail.gmail.com>
John Tapsell wrote:
Show 11 quoted lines
> 2009/3/9 Andreas Ericsson <ae@op5.se>: >> John Tapsell wrote: > >> Not really. If bugs are in "unrelated" areas (if the topic changed some >> API without changing its' other callers, fe), you can backstep between >> each commit on the merged branch, remerge that commit (instead of the >> tip) and then run the tests again. > > Doing that manually? Sounds really complicated, especially if the > merge is nontrivial. >
Well, using git bisect should work.
Show 7 quoted lines
>> But really, such bugs should have >> been detected prior to merging the branch, and in any case "git bisect" >> will find the commit that introduced the bug for you either way. > > How will you detect bugs that arise from merging two trees, before you > merge them? >
Assuming you don't start each topic-branch from a completely empty tree and that you have *some* tests, you can run those tests at every single commit just as if you had done those on the 'master' branch. API changes that break things should break earlier, unless another branch made those changes.
Aside from that, it's quite simple to run tests before publishing the results of the merge, and it's absolutely trivial to undo the merge in case tests don't pass.
Show 7 quoted lines
>> For next time, please cut away those parts of the email you didn't >> reply to. I had to scroll down to the bottom to make sure you hadn't >> written more. > > I'll try sorry. Most email clients will hide the quoted text - there > might be an option for that in your client? >
I'm sure there is, but then I wouldn't have seen what you were replying to, so that's not a very good option. In the space between me sending and you replying, I wrote six other emails. Keeping track of them all in my head is not something I'm prepared to even consider trying.
-- Andreas Ericsson andreas.ericsson@op5.se OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231 Considering the successes of the wars on alcohol, poverty, drugs and terror, I think we should give some serious thought to declaring war on peace.