Re: [PATCHv3 2/2] git submodule: Fix adding of submodules at paths with ./, .. and //

From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Mar 3, 2009, 14:09 UTC
Message-ID: <49AD3A29.10404@drmicha.warpmail.net>
In-Reply-To: <49AD2BE6.1000105@viscovery.net>

Johannes Sixt venit, vidit, dixit 03.03.2009 14:08:

Show 13 quoted lines

> Michael J Gruber schrieb:
>> +	# normalize path:
>> +	# multiple //; leading ./; /./; /../; trailing /
>> +	path=$(printf '%s/\n' "$path" |
>> +		sed -e '
>> +			s|//*|/|g
>> +			s|^\(\./\)*||
>> +			s|/\./|/|g
>> +			:start
>> +			s|\([^/]*\)/\.\./||g
> 
> Sorry to say: not yet. This turns "a/b/c/d/../../../d" into "a/b/c/d"
> instead of "a/d". Drop the 'g'.

Shoot, I thought I had a complete test case... Thanks for spotting.

> Once this is fixed, I have to ask what should happen with path names like
> "../a/b", "../../a/b"? Should there be a warning or error?

That triggers the error message when trying to git add a submodule which is not within the current wc. Same before and after the patch, and I think that's how it should be.

> Other than that, this expression works on AIX 4.3.3! Note in particular
> that '\n' in the printf format string is essential!

I learned that from you ;)

Michael

Show 7 quoted lines

> 
>> +			tstart
>> +			s|/*$||
>> +		')
> 
> -- Hannes
>