Re: jgit and ignore

From: Tor Arne Vestbø <torarnv@gmail.com>
Date: Mar 1, 2009, 13:34 UTC
Message-ID: <49AA8ECD.4090302@gmail.com>
In-Reply-To: <49AA884D.1050806@pelagic.nl>

Ferry Huberts (Pelagic) wrote:

Show 5 quoted lines

> BTW. the plugin will not look at the eclipse filter for ignore files
> once I've finished the implementation. that's the only way to make sure
> that we ignore resources in exactly the same way as git does: git only
> ignores on the basis of .gitignore files, command line options (we do
> not have those for the plugin), and the info/exclude file in the repository.

You're missing one: the file specified by the configuration variable core.excludesfile, which can be though of as a global ignore filter.

The manual says:

"Patterns which a user wants git to ignore in all situations (e.g., backup or temporary files generated by the user's editor of choice) generally go into a file specified by core.excludesfile in the user's ~/.gitconfig."

This is _exactly_ what Eclipse's Team->Ignored Resources is for.

I see two groups of users: a) those with a global ignore specified in core.excludesfile b) and those without (they may not even have cgit installed, if EGit is bundled with Eclipse in the future).

In my opinion, EGit should default to using Eclipse's built in ignores, but then detect the presence of a global core.excludesfile, in which case it would notify the user ("I see you have a core.excludesfile") and let the user switch to using that one instead.

In other words, whether or not to use core.excludesfile or Eclipse's global team ignores should be optional, and we should provide heuristics for deciding when to switch.

I think that would cover both groups of users without causing confusion.

Tor Arne