Re: [PATCH] Add bare repository indicator for __git_ps1

From: Marius Storm-Olsen <marius@storm-olsen.com>
Date: Feb 24, 2009, 19:47 UTC
Message-ID: <49A44EC6.3070800@storm-olsen.com>
In-Reply-To: <7vljrvixa3.fsf@gitster.siamese.dyndns.org>

Junio C Hamano said the following on 24.02.2009 18:01:

Show 13 quoted lines

> Ted Pavlic <ted@tedpavlic.com> writes:
>>>> Keep in mind that "BARE:master" doesn't make much sense. If
>>>> you're
>>> It reflects what HEAD points to in the bare repository.
>> Obviously, but that seems disingenuous when you're inside the git
>>  dir. "HEAD" is supposed to reflect the name of the currently 
>> checked-out branch, and so it is tied to a working directory. I'm
>> not sure why it's useful to show $GIT_DIR/HEAD in PS1 while
>> inside .git as it invites operations that probably should not be
>> done while within the bare repo.
> 
> It still indicates the branch in interest.  That's the one you get
> a checkout for when you clone from the repository.

Junio, unfortunately you applied the incorrect version.

It was v3 (Message-Id: <1235244057-16912-1-git-send-email-git@storm-olsen.com>) which was the correct one, since it's the one that avoids the "GIT_DIR!" in a bare repo. :-/

-- .marius