Re: [PATCH] Make git blame date output format configurable, a la git log

From: Eugene Letuchy <eletuchy@facebook.com>
Date: Feb 20, 2009, 13:55 UTC
Message-ID: <499EB647.30606@facebook.com>
In-Reply-To: <alpine.DEB.1.00.0902201434460.6302@intel-tinevez-2-302>

Hi Johannes,

Thanks for your feedback. Any comments on the .c changes?

I'll modify the commit message to read as follows: """

Add the following:
  - git config value blame.date that expects one of the git log date
    formats ({relative,local,default,iso,rfc,short})
  - git blame command line option --date-format expects one of the git
    log date formats ({relative,local,default,iso,rfc,short})
  - documentation in blame-options.txt
  - git blame uses the appropriate date.c functions and enums to
    make sense of the date format and provide appropriate data

The tests pass. The mailmap test needed to be modified to expect iso formatted blames rather than the new "default".

Signed-off-by: Eugene Letuchy <eugene@facebook.com>
"""

-Eugene

+ cc: junio

On 2/20/09 5:40 AM, Johannes Schindelin wrote:

Show 41 quoted lines

> Hi,
>
> Disclaimer: if you are offended by constructive criticism, or likely to
> answer with insults to the comments I offer, please stop reading this mail
> now (and please to not answer my mail, either). :-)
>
> Still with me?  Good.  Nice to meet you.
>
> Just out of curiosity: why Cc: Marius?  I would have expected Junio, Git's
> maintainer.
>
> May I suggest the commit subject to say "as for git log"?  I mistook "a la
> git log" for a change in the way git-blame works...
>
> On Fri, 20 Feb 2009, eletuchy@gmail.com wrote:
>
>> From: Eugene Letuchy<eugene@facebook.com>
>>
>> Adds the following:
>
> We try to use the imperative form; from my experience it makes for an
> easier read: "Add the following:"
>
>>   - git config value blame.date that expects one of the git log date
>>     formats ({relative,local,default,iso,rfc,short})
>>   - git blame command line option --date-format expects one of the git
>>     log date formats ({relative,local,default,iso,rfc,short})
>>   - documentation in blame-options.txt
>>   - git blame uses the appropriate date.c functions and enums to
>>     make sense of the date format and provide appropriate data
>>
>> The tests pass. The mailmap test needed to be modified to expect iso
>> formatted blames rather than the new "default".
>
> IMHO the "The tests pass." should be removed.
>
> Other than that, nicely done!
>
> Ciao,
> Dscho
>