git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [EGIT PATCH 06/11] Implement basic customizable label decorations with preferences

From
Tor Arne Vestbø <torarnv@gmail.com>
Date
Feb 5, 2009, 21:00 UTC
Message-ID
<498B5374.1030305@gmail.com>
In-Reply-To
<498B4A66.9020108@gmail.com>
Tor Arne Vestbø wrote:
Show 5 quoted lines
>> I miss the red attention-gathering red conflict icon we had.
> 
> Happy to replace. If I remember correctly that's the symbol used by
> other plugins to indicate conflicts, so I was aiming for consistency and
> recognizability.

Okey, I've replaced the blue one with the default conflict icon from the team org.eclipse.team.ui plugin, what can be more consistent then that? :) See mockup below.

Show 7 quoted lines
>> I also have a hard time distinguishing the staged/added/removed icons
>> without reading glasses. The decorations are only 1.3 mm on my 
>> screen (150 dpi), so I think the icons should have different colors
>> and different shapes instead of a few different pixels withing a
>> square box.>
> 
> Noted, I'll try to make some mocukups of variations to the icons.

Here are two alternatives. The first one (A) uses the same icons as before, but adds red and green shading. The second one (B) uses the green plus sign for added (which is used all over the place in Eclipse to mean 'added'), and the gray x for removed (which is also used all over the place in Eclipse for that same concept).

http://img443.imageshack.us/img443/5138/egitmockupmm7.png

I favor solution B, as it uses recognizable concepts from the existing Eclipse UI, plus that having a red removed-icon conflicts too much with the conflict-icon (pun intended). There's also a very similar red icon in JDT that indicates that something needs fixing (a red medic kit), which is another reason to go with solution B.

What do you say?
Tor Arne
Show 13 quoted lines
> 
>> I'd also like to see the conflict state for files inherited by parent
>> folder and projects.
> 
> Good idea, like the synchronize view shows it. Noted.
> 
>> The checkboxes in the general tab have no effect on the preview.
> 
> True. Should be easy to fix.
> 
> Thanks for the feedback!
> 
> Tor Arne
Previous: Tor Arne VestbøNext: Robin Rosenberg
Message 15 of 31 in “Support customizable label decorations”
  1. 00/11 Support customizable label decorationsTor Arne Vestbø, Feb 5, 2009
  2. 01/11 Add support code to handle plugin property changesTor Arne Vestbø, Feb 5, 2009
  3. 02/11 Use Set instead of array to keep track of change listenersTor Arne Vestbø, Feb 5, 2009
  4. 03/11 Add a specialized team exception for GitTor Arne Vestbø, Feb 5, 2009
  5. 04/11 Add new class ExceptionCollector for grouping exceptionsTor Arne Vestbø, Feb 5, 2009
  6. 05/11 Add new class SWTUtils with helper-methods for creating controlsTor Arne Vestbø, Feb 5, 2009
  7. 06/11 Implement basic customizable label decorations with preferencesTor Arne Vestbø, Feb 5, 2009
  8. 07/11 Add binding for name of the current branchTor Arne Vestbø, Feb 5, 2009
  9. 08/11 Add icon decoration for tracked and untracked resourcesTor Arne Vestbø, Feb 5, 2009
  10. 09/11 Implement decorations of dirty, staged, and conflicting resourcesTor Arne Vestbø, Feb 5, 2009
  11. 10/11 Don't decorate every single resource on repository changeTor Arne Vestbø, Feb 5, 2009
  12. 11/11 Implement label decorations for folders and projectsTor Arne Vestbø, Feb 5, 2009
  13. Robin RosenbergFeb 5, 2009
  14. Tor Arne VestbøFeb 5, 2009
  15. Tor Arne VestbøFeb 5, 2009
  16. Robin RosenbergFeb 5, 2009
  17. Tor Arne VestbøFeb 5, 2009
  18. Robin RosenbergFeb 5, 2009
  19. Shawn O. PearceFeb 5, 2009
  20. Tor Arne VestbøFeb 5, 2009
  21. 02/11 Use Set instead of array to keep track of change listenersTor Arne Vestbø, Feb 5, 2009
  22. Shawn O. PearceFeb 5, 2009
  23. Tor Arne VestbøFeb 5, 2009
  24. Shawn O. PearceFeb 5, 2009
  25. Add support code to handle plugin property changesTor Arne Vestbø, Feb 5, 2009
  26. Tor Arne VestbøFeb 5, 2009
  27. Shawn O. PearceFeb 5, 2009
  28. Tor Arne VestbøFeb 5, 2009
  29. Robin RosenbergFeb 5, 2009
  30. Tor Arne VestbøFeb 5, 2009
  31. Robin RosenbergFeb 5, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.