Re: [fsck] What's cooking in git.git (Feb 2009, #02; Wed, 04)

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Feb 5, 2009, 09:42 UTC
Message-ID: <498AB471.1000609@viscovery.net>
In-Reply-To: <7vr62dk6ru.fsf@gitster.siamese.dyndns.org>

Junio C Hamano schrieb:

Show 11 quoted lines

> * jc/fsck (Fri Jan 30 02:44:13 2009 -0800) 5 commits
>  - fsck: revert --quick to the default and introduce --medium
>  - fsck: three levels of validation
>  - verify-pack: add --quick
>  - verify_pack(): allow a quicker verification for a pack with
>    version 2 idx
>  - pack-check.c: minor formatting fix to match coding style
> 
> I haven't heard anything positive nor negative about this series.  I think
> the tip two commits should be squashed (and perhaps the option parser
> cleaned up as suggested on the list).

If you *do* squash the top two commits due to the surprisingly expensive --medium check level, what is the whole point of the series?

That is, if I can have a reasonably thorough check only by passing an option to 'git fsck', then why would I want to choose --medium when I can have --full for only a 30% higher price (according to the timings you gave)?

-- Hannes