git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] http-push: add back underscore separator before lock token

From
Tay Ray Chuan <rctay89@gmail.com>
Date
Feb 3, 2009, 13:07 UTC
Message-ID
<4988418E.4000808@gmail.com>

The patch dated Sat, 31 Jan, "[PATCH] http-push: refactor request url creation" inadvertently removed the underscore separator between the object path and the appended lock token.

This patch adds it back.

This would be keeping in line with the aforementioned patch's objective of refactoring, without changing the behaviour and effect, of the code.

This would also be useful for testing if the lock token has been indeed appended to the object url.

Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
---
 http-push.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/http-push.c b/http-push.c
index 54c62d4..eefd64c 100644
--- a/http-push.c
+++ b/http-push.c
@@ -557,6 +557,7 @@ static void start_put(struct transfer_request *request)
 	request->dest = strbuf_detach(&buf, NULL);

 	append_remote_object_url(&buf, remote->url, hex, 0);
+	strbuf_addstr(&buf, "_");
 	strbuf_addstr(&buf, request->lock->token);
 	request->url = strbuf_detach(&buf, NULL);
-- 
1.6.1.2.278.g9a9e.dirty
Next: Junio C Hamano
Message 1 of 2 in “http-push: add back underscore separator before lock token”
  1. http-push: add back underscore separator before lock tokenTay Ray Chuan, Feb 3, 2009
  2. Junio C HamanoFeb 4, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.