Re: [PATCH] git-svn: add --ignore-paths option for fetching

From: public_vi <public_vi@tut.by>
Date: Jan 25, 2009, 16:29 UTC
Message-ID: <497C9354.5050902@tut.by>
In-Reply-To: <200901251521.15591.trast@student.ethz.ch>

It is useful for me, but I think I can be useful for others too. May be it's better to make in inclusive, i.e. "--only-matching=<regex>"?

> This would be a good place to explain why this is useful, and (if
> applicable) why you chose to implement it the way you did.
>

OK, fixing them.

Show 13 quoted lines

> You put the --ignore-paths explanation in the middle of the
> --localtime documentation (the last paragraph quoted still talks about
> --localtime).
>   
> This is the first function in git-svn.perl using camelCase.  Consider
> sticking to the current style and spelling it is_path_ignored().
>
> You broke the symmetry here, while all other hunks just add an
> equivalent check to the existing in_dot_git().
>
> However, the latter makes me wonder if it would be cleaner to move the
> in_dot_git() test to isPathIgnored (er, is_path_ignored) too?
>