Re: [PATCH] Fix 'git add' with .gitignore (Re: git-add ignores .gitignore)

From: Brian Gernhardt <benji@silverinsanity.com>
Date: Dec 30, 2006, 14:50 UTC
Message-ID: <497AFE26-3192-4265-820D-EED80B3452DC@silverinsanity.com>
In-Reply-To: <7vpsa2msx2.fsf@assigned-by-dhcp.cox.net>

On Dec 29, 2006, at 1:57 PM, Junio C Hamano wrote:

Show 10 quoted lines

> Thanks for noticing.
>
> The commit 4888c534 tried to mark the path it returns so that
> the caller can tell if it is ignored or not, but botched the
> case where a directory is ignored.  It should have marked the
> contents as ignored if higher level directory was.
>
> But I think the approach that change makes is more expensive
> than the original code and is not necessary.  How about this
> patch, after you revert that commit?

Tried it and it works for me!  Thanks.

~~ Brian