[RFC/PATCH] git-web--browse: don't add start as candidate on Ubuntu

From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date: Jan 1, 2009, 21:45 UTC
Message-ID: <495D3964.6040006@ramsay1.demon.co.uk>

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---

Hi *,

When upgrading to v1.6.1, I noticed that the html help had stopped working on Linux (Ububtu), viz:

    $ git help -w tag
    start: Need to be root

So, after squinting at git-web--browse.sh, I tried a few things:

    $ ls /bin/start
    ls: /bin/start: No such file or directory
    $ test -n /bin/start; echo $?
    0
    $ which start
    /sbin/start
    $ start fred
    start: Need to be root
    $ ls -l /sbin/start
    lrwxrwxrwx 1 root root 7 2007-06-24 19:45 /sbin/start -> initctl*

So, it would seem that /sbin/start is part of upstart, which would explain the "Need to be root" ;-)

    $ test -x /bin/start; echo $?
    1
    $

So, the patch below fixes the issue for me, but as I don't have MinGW installed, I can't test this fix works there.

Does anybody else see this issue and can someone test the patch?

ATB, Ramsay Jones

 git-web--browse.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/git-web--browse.sh b/git-web--browse.sh
index 78d236b..7ed0fad 100755
--- a/git-web--browse.sh
+++ b/git-web--browse.sh
@@ -115,7 +115,7 @@ if test -z "$browser" ; then
 	browser_candidates="open $browser_candidates"
     fi
     # /bin/start indicates MinGW
-    if test -n /bin/start; then
+    if test -x /bin/start; then
 	browser_candidates="start $browser_candidates"
     fi

-- 
1.6.1