Re: [PATCH] ls-tree: add --full-tree option

From: Johannes Sixt <j6t@kdbg.org>
Date: Dec 26, 2008, 19:49 UTC
Message-ID: <49553561.4030902@kdbg.org>
In-Reply-To: <7vmyejpb6o.fsf@gitster.siamese.dyndns.org>

Junio C Hamano schrieb:

Show 13 quoted lines

> Johannes Sixt <j6t@kdbg.org> writes:
> 
>> On Freitag, 26. Dezember 2008, Junio C Hamano wrote:
>>> This new option makes the command operate on the full tree object,
>>> regardless of where in the work tree it is run from.  It also implies the
>>> behaviour that is triggered by the existing --full-name option.
>> What's wrong with using 'git ls-tree ${rev}:'?
>>
>> Except that it does not work...
> 
> Hmph... you seem to be describing the exact issue they discussed on #git,
> which triggered the patch in the message you are responding to.  I am not
> sure what to say to your "What's wrong with...".

I'm saying that if a script has to be fixed to use --full-tree, then it can be fixed just as well by appending the colon to the ${rev}.

Not even porcelain 'git show ${rev}:' "is allowed" to insert the prefix. Dscho has argued the case passionately in the past:

http://thread.gmane.org/gmane.comp.version-control.git/68786/focus=68846

Therefore, plumbing 'ls-tree ${rev}:' shouldn't do that, either.

OTOH, you had yourself argued somewhat in favor of the current ls-tree behavior:

http://thread.gmane.org/gmane.comp.version-control.git/46232/focus=46400

I'm personally more in line with Dscho, and think that the current ls-tree behavior is a terrible bug.

-- Hannes