Re: [PATCH] Makefile: introduce NO_PTHREADS
- From
Johannes Sixt <j.sixt@viscovery.net>
- Date
- Nov 17, 2008, 10:34 UTC
- Message-ID
- <492148AD.1090604@viscovery.net>
- In-Reply-To
- <e2b179460811170203v41e54ecclc3d6526bcc0fe928@mail.gmail.com>
Mike Ralphson schrieb:
Show 12 quoted lines
> 2008/11/15 Linus Torvalds <torvalds@linux-foundation.org>: >> On Sat, 15 Nov 2008, Junio C Hamano wrote: >>> This introduces make variable NO_PTHREADS for platforms that lack the >>> support for pthreads library or people who do not want to use it for >>> whatever reason. When defined, it makes the multi-threaded index >>> preloading into a no-op, and also disables threaded delta searching by >>> pack-objects. >> Ack. Makes sense. > > I'd be minded to make this the default on AIX to keep the prerequisite > list as small as possible, then people can opt-in for the performance > benefits if required.
Is pthreads not a standard shipment on AIX? I would set NO_PTHREADS only if we know in advance that there are many installations without pthreads. (And I don't know what the situation is.)
BTW, this needs to be squashed in, because we don't have pthreads on Windows:
diff --git a/Makefile b/Makefile index ffc9531..3a30b8c 100644 --- a/Makefile +++ b/Makefile @@ -769,6 +769,7 @@ ifneq (,$(findstring MINGW,$(uname_S))) NO_STRCASESTR = YesPlease NO_STRLCPY = YesPlease NO_MEMMEM = YesPlease + NO_PTHREADS = YesPlease NEEDS_LIBICONV = YesPlease OLD_ICONV = YesPlease NO_C99_FORMAT = YesPlease -- Hannes