Re: [PATCH] diff/diff-files: do not use --cc too aggressively

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Sep 18, 2008, 09:30 UTC
Message-ID: <48D21FB2.50700@viscovery.net>
In-Reply-To: <7v7i99zuqh.fsf_-_@gitster.siamese.dyndns.org>

Junio C Hamano schrieb:

Show 6 quoted lines

> Textual diff output for unmerged paths was too eager to give condensed
> combined diff.  This has two problems:
> 
>  (1) "diff --base/--ours/--theirs" (and "diff-files -p" with the same) is
>      a request to compare with the named stage.  We showed "-c -p" output
>      instead;

I cannot reproduce what you describe here. "diff --base/--ours/--theirs" works as expected with and without this patch.

>  (2) "diff -c" (and "diff-files -c -p") is a request to view combined diff
>      without condensing (otherwise the user would have explicitly asked
>      for --cc, not -c).  We showed "--cc" output anyway.

The patch fixes this:

Tested-by: Johannes Sixt <johannes.sixt@telecom.at>

-- Hannes