Re: [PATCH 4/4] diff.c: convert builtin funcname patterns to extended regular expressions

From: Andreas Ericsson <ae@op5.se>
Date: Sep 18, 2008, 07:18 UTC
Message-ID: <48D200D7.9080800@op5.se>
In-Reply-To: <-f-gqL4SkA8Uh7hSuKT-JDY0g26jHn3fDQCE24MB1nKWUMLZWuSseg@cipher.nrlssc.navy.mil>

Brandon Casey wrote:

Show 18 quoted lines

> Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
> ---
> 
> 
> This is a blind conversion removing \\ before ( and { etc.
> and adding \\ before naked ( and { etc.
> 
> I hope the authors who last touched these patterns will help with testing:
> 
> bibtex: Johan Herland
>   html: Johan Herland
>   java: Junio Hamano, Jeff King
> pascal: Avery Pennarun
>    php: Andreas Ericsson
> python: Kirill Smelkov
>   ruby: Giuseppe Bilotta
>    tex: Johan Herland
>

The PHP one seems to work just fine.

Signed-off-by: Andreas Ericsson <ae@op5.se>

Nicely done, although I'd rather have "ereg_funcname" instead of "xfuncname", but I don't care very much for myself, as I'll rather submit my patterns upstream than add them to .git/config ;-)

Junio: Can we issue a deprecation heads-up for the current "funcname" along with a "call for patterns" and then have "funcname" and "ereg_funcname" mean the same for a while until we obsolete ereg_funcname in favour of funcname, perhaps? I can't imagine anyone wanting to use posix regular expressions if extended ones are available everywhere.

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231