Re: [PATCH] change Perl syntax to support Perl 5.6

From: Tom G. Christensen <tgc@statsbiblioteket.dk>
Date: Sep 5, 2008, 06:34 UTC
Message-ID: <48C0D30B.4030302@statsbiblioteket.dk>
In-Reply-To: <fUNB92Q2XygkBhhleaxyWUGW8Ecwa-lU403JuDrY0JMrT1kmsFkWwg@cipher.nrlssc.navy.mil>

Brandon Casey wrote:

Show 8 quoted lines

> Tom G. Christensen wrote:
> 
>> On RHEL 2.1 git 1.6.0.1 currently builds fine and it passes the
>> testsuite except for the tests using --interactive.
> 
> Even t9700-perl-git.sh? Or perhaps it is skipped since Test::More
> is missing?
>

Exactly.

Show 11 quoted lines

> t9700-perl-git.sh doesn't run successfully for me on perl 5.8.0 without
> changes since test.pl uses
> 
>     'File::Temp->new()'
> 
> object form, and
> 
>     'open our $tmpstderr, ">&", STDERR'
> 
> bare STDERR as 3rd argument which this perl version complains about.
>

I saw your patch for this. I haven't got this far with 5.8.0 since t9100-git-svn-basic.sh kills the build because of File::Temp->new() in Git.pm.

-tgc