Re: git packs

From: bob <kranki@mac.com>
Date: Nov 11, 2007, 12:54 UTC
Message-ID: <48B406B0-FA9D-4173-B2DF-A01B193E5338@mac.com>
In-Reply-To: <20071111110942.A4013@edi-view2.cisco.com>

Well, there are actually two problems here. The first is that crashreporter crashed trying to create the crash report of the git failure. The second was the error in git itself. Hope that helps.

I am submitting an Apple bugreport on the first and Nicolas Pitre is probably correct in his fix. When I was looking at index-pack.c everything was using 32 bit unsigned and signed number where off_t was 64-bit which is what a stat() would return. My problem is that I was not familiar enough with git internals to figure out the solution. My review was the first time that I ever looked at git source.

Thanks, Nicolas

On Nov 11, 2007, at 6:09 AM, Derek Fawcus wrote:

Show 13 quoted lines

> On Sat, Nov 10, 2007 at 01:01:46PM -0500, bob wrote:
>> It is fairly disappointing as far as indicating the problem.  Here is
>> the entire report since it was so short.
>
>> Error Formulating Crash Report:
>> *** -[NSCFDictionary setObject:forKey:]: attempt to insert nil value
>> (key: VMUSignaturePath)
>
> huh?  The above looks like an ObjC invocation.  Last I checked,   
> git was C.
> So why is that in the frame?
>
> DF