Re: [PATCH] bash-completion: fix getting strategy list

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Aug 19, 2008, 14:57 UTC
Message-ID: <48AADF3E.40304@viscovery.net>
In-Reply-To: <48AADDBB.1080203@viscovery.net>

Johannes Sixt schrieb:

Show 9 quoted lines

> Nguyen Thai Ngoc Duy schrieb:
>> +	if (argc == 2 && !strcmp(argv[1], "--show-strategies")) {
>> +		for (i = 0; i < ARRAY_SIZE(all_strategy); i++)
>> +			printf("%s\n", all_strategy[i].name);
>> +		return 0;
> 
> Improved error checking, but quick and dirty:
> 
> +	if (!strcmp(argv[1], "--show-strategies")) {

Oops, not really improved. This still needs to check for argc >= 2.

Show 5 quoted lines

> +		for (i = 0; i < ARRAY_SIZE(all_strategy); i++)
> +			printf("%s\n", all_strategy[i].name);
> +		return argc == 2 ? 0 :
> +			 error("--show-strategies does not take "
> +				"any arguments");

-- Hannes