git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [EGIT PATCH] Fix invalid menubar and toolbar entries in plugin.xml

From
Tor Arne Vestbø <torarnv@gmail.com>
Date
Aug 14, 2008, 19:13 UTC
Message-ID
<48A483EF.10508@gmail.com>
In-Reply-To
<200808141942.55448.robin.rosenberg.lists@dewire.com>
Robin Rosenberg wrote:
>>> The menu entry was not used, and was causing an extra
>>> empty space in the menu bar.
> 
> When I applied this patch the Git menu disappeared. (3.3)

Ah, I see. It appears the menu was used, but because it had the wrong path ('org.spearce.egit.ui.gitmenu' instead of 'additions') the four entries did not show up in 3.4.

Either way I suggest the patch is still valid, because it removes the Git menu from the menu bar. This is consistent with what other platform plugins do, ie. not populating the main menu bar with plugin specific entries, but instead using sub menus, context menus and views.

In the long run we should probably also move the global toolbar entries to the synchronize view, when I get the chance to look at implementing that. 

Tor Arne
Previous: Robin RosenbergNext: Robin Rosenberg
Message 4 of 8 in “Fix invalid menubar and toolbar entries in plugin.xml”
  1. Fix invalid menubar and toolbar entries in plugin.xmlTor Arne Vestbø, Aug 13, 2008
  2. Robin RosenbergAug 14, 2008
  3. Robin RosenbergAug 14, 2008
  4. Tor Arne VestbøAug 14, 2008
  5. Robin RosenbergAug 14, 2008
  6. Hide the Git menu and toolbars by default and fix the path of the Git menuRobin Rosenberg, Aug 14, 2008
  7. Tor Arne VestbøAug 14, 2008
  8. Fix invalid menubar and toolbar entries in plugin.xmlTor Arne Vestbø, Aug 14, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.