Re: [PATCH] correct access right for git-svn-dcommit test
- From
Brad King <brad.king@kitware.com>
- Date
- Aug 4, 2008, 15:44 UTC
- Message-ID
- <489723C6.7060806@kitware.com>
- In-Reply-To
- <20080804153024.GV7008@dpotapov.dyndns.org>
Dmitry Potapov wrote:
Show 23 quoted lines
> The tests requires anonymous write access. Therefore, "anon-access =
> write" is added to conf/svnserve.conf. But because it was added to
> the end of the file, it is impossible to guarantee in what section
> it will be located. It turned out that on SVN 1.5, it was placed in
> the wrong section and as result the test failed.
>
> Signed-off-by: Dmitry Potapov <dpotapov@gmail.com>
> ---
> t/t9113-git-svn-dcommit-new-file.sh | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/t/t9113-git-svn-dcommit-new-file.sh b/t/t9113-git-svn-dcommit-new-file.sh
> index 8da8ce5..ae78e33 100755
> --- a/t/t9113-git-svn-dcommit-new-file.sh
> +++ b/t/t9113-git-svn-dcommit-new-file.sh
> @@ -28,6 +28,7 @@ start_svnserve () {
>
> test_expect_success 'start tracking an empty repo' '
> svn mkdir -m "empty dir" "$svnrepo"/empty-dir &&
> + echo "[general]" > "$rawsvnrepo"/conf/svnserve.conf &&
> echo anon-access = write >> "$rawsvnrepo"/conf/svnserve.conf &&
> start_svnserve &&
> git svn init svn://127.0.0.1:$SVNSERVE_PORT &&I just tried this patch and it does fix the test on my system.
Thanks, -Brad