Re: THREADED_DELTA_SEARCH

From: Andreas Ericsson <ae@op5.se>
Date: Jul 10, 2008, 16:50 UTC
Message-ID: <48763DBB.3040708@op5.se>
In-Reply-To: <4875C1CF.1010604@viscovery.net>

Johannes Sixt wrote:

Show 11 quoted lines

> Pierre Habouzit schrieb:
>>   I'm using it in production for quite a long time now, and I wonder if
>> there is any specific reason why it's not default. Debian activated it
>> by default too a couple of weeks ago, which means that it's in
>> production on quite a large scale, and there are no issues reported
>> either. Would a patch making it default be accepted ? It's quite handy
>> given that SMP machines are really pervasive nowadays…
> 
> Don't forget to turn it off in the MINGW section in the Makefile since we
> don't have pthreads on Windows.
>

I started trying that, but ran into problems almost immediately. Enabling pthreads by default and disabling it for certain systems means we screw over those poor sods that have their own config.mak files on systems where there's no <pthread.h> to include, or where that header file requires a bunch of other stuff to be in first.

On the one hand, that's not nice. On the other hand, those who have a config.mak are probably savvy enough figure out how to amend it disable threads as well.

Opinions? I'm all for enabling THREADED_DELTA_SEARCH by default. I've been using it ever since v1.5.4.3-193-g833e3df when using the same .gitconfig on all my systems became a sane thing to do and I haven't seen any ill effects what so ever from it, but how much can we screw the build-system in place today, and what other systems would, by default, require the NO_PTHREADS option in the Makefile?

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231