git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Skip unwritable tests for root

From
LWLea Wiemann <lewiemann@gmail.com>
Date
Jul 7, 2008, 19:14 UTC
Message-ID
<48726AFE.3070400@gmail.com>
In-Reply-To
<7vabh31e9p.fsf@gitster.siamese.dyndns.org>
Junio C Hamano wrote:
> If we were to do anything, don't we rather want to fail everything upfront
> when the tests are run by root [because it's crazy]?

I think that unless/until someone wants to submit a patch that makes the tests fail upfront, we should use Fernando's patch; it's an improvement over the current situation.

I'm actually not entirely sure if skipping or failing everything if the tests are run as root is a good idea -- for instance, neither skipping nor failing seems appropriate for Gentoo's root-in-a-sandbox situation.

Jakub Narebski wrote:
Show 6 quoted lines
> "Fernando J. Pereda" <ferdy@ferdyx.org> writes:
>> +	test_expect_success '[...], skipping test' :
>> +	test_done
>> +	exit
>
> Yet another place that would profit from test_skip in test-lib.sh...

*nods* I'd rather name it 'test_skip_all' for clarity though, at least if it contains "test_done; exit". (I'm not volunteering to send a patch, FTR...)

Previous: Fernando J. Pereda
Message 5 of 5 in “Skip unwritable tests for root”
  1. Skip unwritable tests for rootFernando J. Pereda, Jun 30, 2008
  2. Jakub NarebskiJun 30, 2008
  3. Junio C HamanoJun 30, 2008
  4. Fernando J. PeredaJun 30, 2008
  5. Lea WiemannJul 7, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.