git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] builtin: make commit_notes function private to notes.c

From
Thiago Farina <tfransosi@gmail.com>
Date
Nov 3, 2010, 04:47 UTC
Message-ID
<48613a1a105a7dc6ed1fa76ac3cdae2ed2a859e4.1288759498.git.tfransosi@gmail.com>
This function was exported in builtin.h but is only used on notes.c.
Signed-off-by: Thiago Farina <tfransosi@gmail.com>
---
 builtin.h       |    1 -
 builtin/notes.c |    2 +-
 2 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/builtin.h b/builtin.h
index f2a25a0..8017ade 100644
--- a/builtin.h
+++ b/builtin.h
@@ -16,7 +16,6 @@ extern const char git_more_info_string[];
 extern void prune_packed_objects(int);
 extern int fmt_merge_msg(struct strbuf *in, struct strbuf *out,
 			 int merge_title, int shortlog_len);
-extern int commit_notes(struct notes_tree *t, const char *msg);
 
 struct notes_rewrite_cfg {
 	struct notes_tree **trees;
diff --git a/builtin/notes.c b/builtin/notes.c
index 6d07aac..89fe169 100644
--- a/builtin/notes.c
+++ b/builtin/notes.c
@@ -271,7 +271,7 @@ static int parse_reedit_arg(const struct option *opt, const char *arg, int unset
 	return parse_reuse_arg(opt, arg, unset);
 }
 
-int commit_notes(struct notes_tree *t, const char *msg)
+static int commit_notes(struct notes_tree *t, const char *msg)
 {
 	struct commit_list *parent;
 	unsigned char tree_sha1[20], prev_commit[20], new_commit[20];
-- 
1.7.3.2.90.gd4c43
Message 1 of 1 in “builtin: make commit_notes function private to notes.c”
  1. builtin: make commit_notes function private to notes.cThiago Farina, Nov 3, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.