git/list[1] front-page[2] threads[3] people[4] search[5] about
 

gitweb: Broken links in blame view

From
LWLea Wiemann <lewiemann@gmail.com>
Date
Jun 22, 2008, 21:37 UTC
Message-ID
<485EC621.7090101@gmail.com>
Hi!

I (or rather, the link checker) has discovered another broken link, this time in gitweb's blame view, which happens if you blame files and it tries to get parents before the initial (first) commit in the repository:

1. Unpack test.git.tar.gz (attached) into gitweb's project root.
2. Make sure $feature{'blame'}{'default'} = [1]; is on in
gitweb_config.perl.
3. Open the following page:
http://localhost/.../gitweb.cgi?p=test.git;a=blame;f=file;h=f8c58d2c88cbcf660f473f8f123ee32db0d0d2be;hb=HEAD
4. Click the gray "1" line number -- you get a "400 - Invalid hash base 
parameter" response (or '403' instead of 400 if you're not on next).

(I've also reproduced this with gitweb revisions from 7 months ago, so it's not related to recent changes.)

Also, probably related, if you open the above blame view by calling 
gitweb.cgi on the command line, you'll see a bogus error message on 
STDERR: "fatal: ambiguous argument 'f891e539f...^': unknown revision" 
Note that f891... is the earliest revision in the repository.
-- Lea
Message 1 of 1 in “gitweb: Broken links in blame view”
  1. Lea WiemannJun 22, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.