Re: [PATCH] test-lib.sh: add --long-tests option

From: Lea Wiemann <lewiemann@gmail.com>
Date: Jun 17, 2008, 07:09 UTC
Message-ID: <48576345.7000809@gmail.com>
In-Reply-To: <7vy7547egk.fsf@gitster.siamese.dyndns.org>

Junio C Hamano wrote:

Show 10 quoted lines

> I am guessing that the reason why you do not unset GIT_TEST_LONG upfront
> in the script is because the user can do:
> 
>         $ GIT_TEST_LONG=t; export GIT_TEST_LONG
>         $ ./t9999-this-test.sh
>         $ ./t9999-that-test.sh
> 
> or even:
> 
> 	$ GIT_TEST_LONG=t make test

Yes, that's the idea.

> If that is the case, however, I wonder if this --long-tests option is even
> necessary.

It's very convenient for development, where you go back and forth between "./t9503-gitweb-Mechanize.sh -v -l" and "./t9503-gitweb-Mechanize.sh -v". All it takes is to add or remove the "-l" at each invocation. So I think the switch is actually quite useful.

-- Lea