git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[JGIT PATCH v4] Implementation of fnmatch and the ignore rules

From
FKFlorian Köberle <florianskarten@web.de>
Date
Jun 13, 2008, 18:30 UTC
Message-ID
<4852BCCA.4030404@web.de>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi

Thanks for the suggestions and comments, the new patches are available here: http://repo.or.cz/w/egit/florian.git?a=shortlog;h=refs/heads/mailinglist-patches-4

I will send them as a reply to this email soon.
The most noticeable change is that I improved the fnmatch functionality.

All character classes of the type [:class:] work now. Other character classes, including the character classes [=class=] and [.class.] will cause a InvalidPatternException. The last two aren't supported at my bash neighter, but are defined in the POSIX standard.

Two other implementation differences are:

The bash shell doesn't support the full range of digits, but my implementatiton does. e.g. ۹ (U+06F9 EXTENDED ARABIC-INDIC DIGIT NINE)

A pattern like [[:] results in a InvalidPatternException in my implementation. The shell has there a strange behavior: if the files "[" and ":" exists then "ls [[:]" shows only ":".

The other main change is that I introduced a AbstractTestCase class which which offers functionality to create temporary folders. RepositoryTestCase extends now from this new class.

An other patch reducing the duplication between AbstractTestCase and RepositoryTestCase class will follow soon, if you like the change.

I also updated all license statements to the 3-clause BSD.

Even if you don't like the last change (the AbstractTestCase change) it would be cool if you would accept at least some patches.

Best regards,
Florian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIUrzK59ca4mzhfxMRAg+XAKDUoEdpil0+qqZ0pgMx/yJYKd2ztwCfe4aI fqJ25VXnX2RWEay9aH4Np6Y= =4i44 -----END PGP SIGNATURE-----

Next: Florian Koeberle
Message 1 of 26 in “Implementation of fnmatch and the ignore rules”
  1. Implementation of fnmatch and the ignore rulesFlorian Köberle, Jun 13, 2008
  2. 01/24 Added the package fnmatch and two exceptions.Florian Koeberle, Jun 13, 2008
  3. 02/24 Added the interface FilePattern.Florian Koeberle, Jun 13, 2008
  4. 03/24 Added the class Rule.Florian Koeberle, Jun 13, 2008
  5. 04/24 Added the iterface Rules.Florian Koeberle, Jun 13, 2008
  6. 05/24 Added the class FileNamePattern.Florian Koeberle, Jun 13, 2008
  7. 06/24 Added the class FilePathPattern.Florian Koeberle, Jun 13, 2008
  8. 07/24 Added the class IgnoreRuleListFactory.Florian Koeberle, Jun 13, 2008
  9. 08/24 Added a Rules interface implementation and a factory for it.Florian Koeberle, Jun 13, 2008
  10. 09/24 Added test class OverallIgnoreRulestest.Florian Koeberle, Jun 13, 2008
  11. 10/24 Added the class PathNotInProjectDirectoryException.Florian Koeberle, Jun 13, 2008
  12. 11/24 Added the class AddRuleListFactory.Florian Koeberle, Jun 13, 2008
  13. 12/24 Formatted Constants class.Florian Koeberle, Jun 13, 2008
  14. 13/24 Added constant REPOSITORY_DIRECTORY_NAME to Constants class.Florian Koeberle, Jun 13, 2008
  15. 14/24 Added class AddRulesFactory.Florian Koeberle, Jun 13, 2008
  16. 15/24 Added the class LightFileTreeIterator and a test for it.Florian Koeberle, Jun 13, 2008
  17. 16/24 Added class LightFileTreeIterable.Florian Koeberle, Jun 13, 2008
  18. 17/24 Added path related constants to the Constants class.Florian Koeberle, Jun 13, 2008
  19. 18/24 Added WorkTree class which can be constructed over Repository.Florian Koeberle, Jun 13, 2008
  20. 19/24 Added the class NoGitRepositoryFoundException.Florian Koeberle, Jun 13, 2008
  21. 20/24 Formatted Repository class.Florian Koeberle, Jun 13, 2008
  22. 21/24 Added findWorkTree method to Repository class.Florian Koeberle, Jun 13, 2008
  23. 22/24 Formatted RepositoryTestCase.Florian Koeberle, Jun 13, 2008
  24. 23/24 Added a super class for RepositoryTestCase with a createTemporaryDirectory() method.Florian Koeberle, Jun 13, 2008
  25. 24/24 Added the test class AddCommandIterationTest.Florian Koeberle, Jun 13, 2008
  26. Robin RosenbergJun 18, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.